Verifier fixes backported to stable kernels?

[Fanael Linithien]

Will the verifier fixes get backported to 3.15 and/or 3.16, or do we
have to wait for 3.17?

I don't want to wait for 3.17. My / has just been eaten by this bug,
and I'm reluctant to reinstall until it's fixed.

[Dave Chinner]

Post by Fanael Linithien
Will the verifier fixes get backported to 3.15 and/or 3.16, or do we
have to wait for 3.17?

What fixes are you talking about? List of commits, please, noting
whether the commit already has a "cc: <***@vger.kernel.org>" in
it or not.

Post by Fanael Linithien
I don't want to wait for 3.17. My / has just been eaten by this bug,
and I'm reluctant to reinstall until it's fixed.

Patch your kernel with the fixes you've identified are necessary,
then - it can take some time for fixes to propagate through the
stable process....

Cheers,

Dave.

[Fanael Linithien]

Post by Dave Chinner
What fixes are you talking about? List of commits, please, noting
it or not.

These are the commits:

400b9d88757c0bfbdfa97014e090ec40a31c1282
67dc288c21064b31a98a53dc64f6b9714b819fd6 (this is the only one with the cc)
5fd364fee81a7888af806e42ed8a91c845894f2d
ad3714b82c631a34724da09a7daa53afcab952fa

Post by Dave Chinner
Patch your kernel with the fixes you've identified are necessary,
then - it can take some time for fixes to propagate through the
stable process....

This is what I'm trying to avoid, out of sheer laziness. I suppose I'm
going to have to do that if I want to have a working linux, though.

[Eric Sandeen]

Post by Fanael Linithien

Post by Dave Chinner
What fixes are you talking about? List of commits, please, noting
it or not.

400b9d88757c0bfbdfa97014e090ec40a31c1282
67dc288c21064b31a98a53dc64f6b9714b819fd6 (this is the only one with the cc)
5fd364fee81a7888af806e42ed8a91c845894f2d
ad3714b82c631a34724da09a7daa53afcab952fa

Post by Dave Chinner
Patch your kernel with the fixes you've identified are necessary,
then - it can take some time for fixes to propagate through the
stable process....

This is what I'm trying to avoid, out of sheer laziness. I suppose I'm
going to have to do that if I want to have a working linux, though.

In what way did this "eat" your root fs? What happened? Also, are you using a CRC-enabled filesystem?

-Eric

[Dave Chinner]

Post by Fanael Linithien

Post by Dave Chinner
What fixes are you talking about? List of commits, please, noting
it or not.

400b9d88757c0bfbdfa97014e090ec40a31c1282
67dc288c21064b31a98a53dc64f6b9714b819fd6 (this is the only one with the cc)
5fd364fee81a7888af806e42ed8a91c845894f2d
ad3714b82c631a34724da09a7daa53afcab952fa

Ok, but please use the "one-line format" when quoting commits.

I.e. this:

$ git log --oneline -n 4 ad3714b
ad3714b xfs: dquot recovery needs verifiers
5fd364f xfs: quotacheck leaves dquot buffers without verifiers
67dc288 xfs: ensure verifiers are attached to recovered buffers
400b9d8 xfs: catch buffers written without verifiers attached

is much more informative to the reader without a git tree to look up
commits.

As it is, those commits have not yet been sent to Linus, hence they
won't yet be accepted by the stable kernel folk. And because they
haven't been sent to Linus yet, I can redo the commits in that topic
branch with the needed stable tags. I've got to add a couple more
fixes that need to go to stable, too, so a pull req won't happen for
a couple of days yet....

Cheers,

Dave.

[Dave Chinner]

Post by Dave Chinner

Post by Fanael Linithien

Post by Dave Chinner
What fixes are you talking about? List of commits, please, noting
it or not.

400b9d88757c0bfbdfa97014e090ec40a31c1282
67dc288c21064b31a98a53dc64f6b9714b819fd6 (this is the only one with the cc)
5fd364fee81a7888af806e42ed8a91c845894f2d
ad3714b82c631a34724da09a7daa53afcab952fa

Ok, but please use the "one-line format" when quoting commits.
$ git log --oneline -n 4 ad3714b
ad3714b xfs: dquot recovery needs verifiers
5fd364f xfs: quotacheck leaves dquot buffers without verifiers
67dc288 xfs: ensure verifiers are attached to recovered buffers
400b9d8 xfs: catch buffers written without verifiers attached

Actually, I'm not going to send this last patch back to older,
stable kernels. I really don't want to have to port random patches
back to older kernels to avoid it generating false positives.

Cheers,

Dave.

[Fanael Linithien]

Post by Dave Chinner
Ok, but please use the "one-line format" when quoting commits.
$ git log --oneline -n 4 ad3714b
[…]
is much more informative to the reader without a git tree to look up
commits.

Okay, I'll try to remember.

Post by Dave Chinner
As it is, those commits have not yet been sent to Linus, hence they
won't yet be accepted by the stable kernel folk. And because they
haven't been sent to Linus yet, I can redo the commits in that topic
branch with the needed stable tags. I've got to add a couple more
fixes that need to go to stable, too, so a pull req won't happen for
a couple of days yet....

Okay, so I really need to patch it manually.